Fix the Path tool erroneously showing editable geometry overlays belonging to hidden Path nodes#2932
Merged
Merged
Conversation
Keavon
force-pushed
the
ignore-hidden-path-nodes
branch
from
b6cc0c8 to
f558712
Compare
Keavon
changed the title
Keavon
requested changes
Jul 25, 2025
Member
Keavon
left a comment
Keavon
left a comment
There was a problem hiding this comment.
This correctly stops showing the overlays for a disabled Path node, but unfortunately does not show any overlays for a previous Path node. Example: draw with the Pen tool, insert a new downstream Path node but disable it, now the Path tool shows no editable overlays for the original shape like expected.
Member
|
Could you also please look into the test failure? Thank you. |
Contributor
Author
|
No |
Keavon
approved these changes
Aug 2, 2025
Keavon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the path node is hidden, don't use it in the path tool.
Closes #2554